Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: add retry for check multi ingest (#27774) #27826

Merged
merged 5 commits into from
Oct 13, 2021
Merged

br: add retry for check multi ingest (#27774) #27826

merged 5 commits into from
Oct 13, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Sep 6, 2021 •
edited
Loading

cherry-pick #27774 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/27826

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/27826:release-5.2-8a7bd559074d

What problem does this PR solve?

Do not run multi ingest check if the store is not online.

What is changed and how it works?

When do check tikv multi ingest support:

  • skip check offline stores
  • Add retry for each store if meets error
  • Fall back to not support instead of return error if all retry failed and the cluster doesn't contains tiflash.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Documentation

Release note 

Do not check multi-ingest when store is offline.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 6, 2021
@ti-srebot ti-srebot mentioned this pull request Sep 6, 2021
Merged
4 tasks
@ti-srebot ti-srebot added component/lightning This issue is related to Lightning of TiDB. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/5.2-cherry-pick labels Sep 6, 2021
@ti-srebot
Copy link
Contributor Author

@glorv you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 6, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 6, 2021
@glorv
Copy link
Contributor

glorv commented Sep 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 22adf8f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2021
@glorv
Copy link
Contributor

glorv commented Sep 28, 2021

@zhouqiang-cl PTAL

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 13, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 2a65748 into pingcap:release-5.2 Oct 13, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.2.2 milestone Oct 20, 2021
@zimulala zimulala mentioned this pull request Oct 25, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@kennytm kennytm kennytm approved these changes

@3pointer 3pointer Awaiting requested review from 3pointer

@sleepymole sleepymole Awaiting requested review from sleepymole

@Little-Wallace Little-Wallace Awaiting requested review from Little-Wallace

Assignees

@glorv glorv

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/lightning This issue is related to Lightning of TiDB. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.2-cherry-pick
Projects
None yet
Milestone
v5.2.2
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-srebot @ti-chi-bot @glorv @kennytm @zhouqiang-cl